🎨 Ignore ManyToOneRel
in get_relational_fields
#429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User is a foreign key on almost all entities. For any given user, I might find it convenient to query all artifacts that the user ingested via:
user.artifact_set.all()
However, I have a hard time imagining a query that looks like so because the result is always going to be exactly one user; the user that’s directly available as
artifact.created_by
Sometimes, I might only have the uid of an artifact. In that case, I can either query the user table or the artifact table directly. Querying the user table will be slightly faster.
The clutter produced by accounting for these backward references is enormous. For instance, on
User
:I conclude that the minimal benefits in convenience for writing queries of the form
user.artifact_set.all()
do not justify the clutter in the API.This present PR is making a change that hides these backward relationships (
ManyToOneRel
).A second PR will create a migration that prevents Django from dynamically generating these attributes.
Internal reference.