Declaring private const types

laminas · Sep 5, 2024 · 97ffb62 · 97ffb62
1 parent 374013d
commit 97ffb62
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 15 deletions.
diff --git a/src/Changelog/BumpAndCommitChangelogVersion.php b/src/Changelog/BumpAndCommitChangelogVersion.php
@@ -10,8 +10,8 @@
 
 interface BumpAndCommitChangelogVersion
 {
-    public const BUMP_MINOR = 'bumpMinorVersion';
-    public const BUMP_PATCH = 'bumpPatchVersion';
+    public const string BUMP_MINOR = 'bumpMinorVersion';
+    public const string BUMP_PATCH = 'bumpPatchVersion';
 
     /**
      * @psalm-param self::BUMP_*     $bumpType

diff --git a/src/Changelog/BumpAndCommitChangelogVersionViaKeepAChangelog.php b/src/Changelog/BumpAndCommitChangelogVersionViaKeepAChangelog.php
@@ -17,9 +17,9 @@
 
 class BumpAndCommitChangelogVersionViaKeepAChangelog implements BumpAndCommitChangelogVersion
 {
-    private const CHANGELOG_FILE = 'CHANGELOG.md';
+    private const string CHANGELOG_FILE = 'CHANGELOG.md';
 
-    private const COMMIT_TEMPLATE = <<< 'COMMIT'
+    private const string COMMIT_TEMPLATE = <<< 'COMMIT'
         Bumps changelog version to %s
 
         Updates the %s file to add a changelog entry for a new %s version.

diff --git a/src/Changelog/ChangelogReleaseNotes.php b/src/Changelog/ChangelogReleaseNotes.php
@@ -13,7 +13,7 @@
 /** @psalm-immutable */
 class ChangelogReleaseNotes
 {
-    private const CONCATENATION_STRING = "\n\n-----\n\n";
+    private const string CONCATENATION_STRING = "\n\n-----\n\n";
 
     /** @psalm-param non-empty-string $changelogFile */
     public static function writeChangelogFile(string $changelogFile, self $releaseNotes): void

diff --git a/src/Environment/EnvironmentVariables.php b/src/Environment/EnvironmentVariables.php
@@ -15,7 +15,7 @@
 /** @psalm-immutable */
 class EnvironmentVariables implements Variables
 {
-    private const LOG_LEVELS = [
+    private const array LOG_LEVELS = [
         '100',
         '200',
         '250',

diff --git a/src/Github/CreateReleaseTextViaKeepAChangelog.php b/src/Github/CreateReleaseTextViaKeepAChangelog.php
@@ -26,7 +26,7 @@
 class CreateReleaseTextViaKeepAChangelog implements CreateReleaseText
 {
     /** @psalm-var non-empty-list<string> */
-    private const DEFAULT_SECTIONS = [
+    private const array DEFAULT_SECTIONS = [
         'Added',
         'Changed',
         'Deprecated',

diff --git a/test/unit/Changelog/BumpAndCommitChangelogVersionViaKeepAChangelogTest.php b/test/unit/Changelog/BumpAndCommitChangelogVersionViaKeepAChangelogTest.php
@@ -209,7 +209,7 @@ private function createMockChangelog(): string
         return $changelogFile;
     }
 
-    private const CHANGELOG_STUB = <<< 'CHANGELOG'
+    private const string CHANGELOG_STUB = <<< 'CHANGELOG'
         # Changelog
         
         All notable changes to this project will be documented in this file, in reverse chronological order by release.

diff --git a/test/unit/Changelog/ChangelogReleaseNotesTest.php b/test/unit/Changelog/ChangelogReleaseNotesTest.php
@@ -161,7 +161,7 @@ public function testMergedInstanceContainsChangelogEntryFromTheInstanceThatHadOn
         $this->assertEquals($expectedEntry, $reflectionProperty->getValue($merged));
     }
 
-    private const CHANGELOG_ENTRY = <<< 'ENTRY'
+    private const string CHANGELOG_ENTRY = <<< 'ENTRY'
         ## 1.0.1 - %s
         
         ### Added
@@ -186,7 +186,7 @@ public function testMergedInstanceContainsChangelogEntryFromTheInstanceThatHadOn
 
         ENTRY;
 
-    private const CHANGELOG_STUB = <<< 'CHANGELOG'
+    private const string CHANGELOG_STUB = <<< 'CHANGELOG'
         # Changelog
         
         All notable changes to this project will be documented in this file, in reverse chronological order by release.

diff --git a/test/unit/Changelog/ReleaseChangelogViaKeepAChangelogTest.php b/test/unit/Changelog/ReleaseChangelogViaKeepAChangelogTest.php
@@ -271,7 +271,7 @@ private function checkoutMockRepositoryWithChangelog(string $origin): string
         return $repo;
     }
 
-    private const INVALID_CHANGELOG = <<< 'END'
+    private const string INVALID_CHANGELOG = <<< 'END'
         # NOT A CHANGELOG
 
         This file is not a changelog.
@@ -282,7 +282,7 @@ private function checkoutMockRepositoryWithChangelog(string $origin): string
 
         END;
 
-    private const READY_CHANGELOG = <<< 'END'
+    private const string READY_CHANGELOG = <<< 'END'
         # Changelog
         
         All notable changes to this project will be documented in this file, in reverse chronological order by release.

diff --git a/test/unit/Github/CreateReleaseTextViaKeepAChangelogTest.php b/test/unit/Github/CreateReleaseTextViaKeepAChangelogTest.php
@@ -209,7 +209,7 @@ private function checkoutMockRepositoryWithChangelog(string $origin): string
         return $repo;
     }
 
-    private const INVALID_CHANGELOG = <<< 'END'
+    private const string INVALID_CHANGELOG = <<< 'END'
         # NOT A CHANGELOG
 
         This file is not a changelog.
@@ -220,7 +220,7 @@ private function checkoutMockRepositoryWithChangelog(string $origin): string
 
         END;
 
-    private const READY_CHANGELOG = <<< 'END'
+    private const string READY_CHANGELOG = <<< 'END'
         # Changelog
         
         All notable changes to this project will be documented in this file, in reverse chronological order by release.
@@ -271,7 +271,7 @@ private function checkoutMockRepositoryWithChangelog(string $origin): string
 
         END;
 
-    private const CHANGELOG_MULTI_SECTION = <<< 'END'
+    private const string CHANGELOG_MULTI_SECTION = <<< 'END'
         # Changelog
         
         All notable changes to this project will be documented in this file, in reverse chronological order by release.