Update simdlib to 4.9.107 + image IO backend #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and PNG image format.
… and PNG image format.
… perfImageLoadSave.cpp.
…ther STBIMAGE_LIBRARY and STBIMAGE_*_VERSION CMake variables?
|
Some benchmark results on an |
|
@s-trinh Your PR is impressive :-) Tell me if I can help On my laptop running Ubuntu 18.04 I found this warnings: I don't know if we should initialize all the elements of the struct or just turn off this warning using |
|
Thanks! @fspindle I will ping you back when it is finished. Don't know yet when 😃 I think it would be interesting to run the benchmarks also on Ubuntu with OpenCV installed from package, macOS and Windows? Warning, I think currently an exception is thrown if a backend is selected but not available (e.g. libjpeg, libpng on Windows). On a different topic and if you have the ressource for a GSoC or an internship. Looks like Travis builds ran out of credit? Builds on Travis are not triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
SimdFree()Some benchmark numbers for Simd image loading/writing: ermig1979/Simd#183
The idea is to have a backend option to select which library is used for image loading/writing, with a default backend.
Always build ViSP with stb and Simd support.
ViSP images: lagadic/visp-images#17