Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zap4echo to README #2324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

karagenc
Copy link

@karagenc karagenc commented Oct 31, 2022

I wrote a middleware package to log requests and to recover from panics. It uses zap, my favorite logging package.

@lammel
Copy link
Contributor

lammel commented Nov 30, 2022

Nice, but how does your package differ from the existing github.com/brpaz/echozap just the line below yours?

@karagenc
Copy link
Author

karagenc commented Dec 5, 2022

echo4zap is highly configurable whereas echozap is not. In addition to that echo4zap has a logger for panic recovery, which is also configurable.

@lammel
Copy link
Contributor

lammel commented Dec 14, 2022

For adding zap4echo I think having both for now seems ok, as zap4echo is more configurable.

@aldas I'd prefer to move the whole third party middlewares seciotn from the README to the echo-contrib project and just add a link in the main repo README to the echo-contrib project. What do you think about that?

@karagenc
Copy link
Author

There was a merge conflict. I solved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants