Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ossm configs #63

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Ossm configs #63

wants to merge 11 commits into from

Conversation

saurabhsadhale
Copy link

@kxr Added ServiceMeshControlPlane, ServiceMeshMemberRoll, and Istio Configuration resources code.

@saurabhsadhale
Copy link
Author

@kxr this test checks for a autocomplete function. When the checks are running the result would get populated with servi* which includes service, servicemeshcontrolplane, servicemeshmemberroll & serviceentry which is why it is getting an error.

Can we change the test or make it more robust ?

@kxr
Copy link
Owner

kxr commented Aug 27, 2021

@saurabhsadhale yes you are right. If you have the time feel free to update the tests. Otherwise I will do it when I am free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurabhsadhale @kxr