fix: moving the golangci-lint condition because it has matrix strategy #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leoporoli i think it being on the top section is okay; we don't want the linter to run if its only a docs change |
@h4ck3rk3y it doesn't work if we don't move it, you can see this example PR> #2222 It doesn't find all the golang-lint jobs because the matrix is not generated, and the branch protection rule is waiting for all of them, so we have to run them, but with the condition in all the steps they will run fast |
h4ck3rk3y
approved these changes
Mar 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.1](0.88.0...0.88.1) (2024-03-05) ### Features * allow users to set descriptions ([#2239](#2239)) ([473d0ee](473d0ee)) ### Bug Fixes * Add retries around the test enclave destroy logic ([#2255](#2255)) ([6245ddf](6245ddf)) * CI failing due deprecated images ([#2253](#2253)) ([742e40b](742e40b)) * moving the golangci-lint condition because it has matrix strategy ([#2242](#2242)) ([f976daa](f976daa)) * rename utils to path compression ([#2236](#2236)) ([d28fdc9](d28fdc9)) * typos ([#2066](#2066)) ([1b6aff7](1b6aff7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
moving the golangci-lint condition because it has matrix strategy
We have to move the condition to the steps section otherwise these jobs won't be executed when a doc's PR is created.
Is this change user facing?
NO
References (if applicable):