feat: allow to specify dockerfile name in image_build_spec
#2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leovct ! Looks like there's still a failing test here: https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/11579/workflows/04b3d332-76f8-4d63-9cdc-b82e936f4fab/jobs/169175?invite=true#step-108-11902_114 and a merge conflict with |
mieubrisse
reviewed
Feb 27, 2024
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/image_build_spec.go
Show resolved
Hide resolved
…geAttr`" This reverts commit 18ff46b.
mieubrisse
approved these changes
Feb 27, 2024
leovct
commented
Feb 27, 2024
...rver/api_container/server/startosis_engine/kurtosis_types/service_config/image_build_spec.go
Outdated
Show resolved
Hide resolved
mieubrisse
added
the
request-cf-deploy
|
Cloudflare is having issues right now, so I'm going to admin-merge this (the rest of the checks passed) |
auto-merge was automatically disabled
February 29, 2024 15:00
Pull request was closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Tracking: seems like there's flakiness in our CI pipeline (tests passed in the PR, but failed in the merge queue): https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/11662/workflows/326000e1-44d9-43d6-b366-d14966c4b808/jobs/170803 @laurentluce to investigate |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.0](0.87.3...0.88.0) (2024-02-29) ### ⚠ BREAKING CHANGES * remove the cloud add and CreateCloudInstance endpoint ([#2234](#2234)) ### Features * allow to specify dockerfile name in `image_build_spec` ([#2223](#2223)) ([d274170](d274170)) ### Miscellaneous Chores * remove the cloud add and CreateCloudInstance endpoint ([#2234](#2234)) ([0f17729](0f17729)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow to specify the Dockerfile name in
ImageBuildSpec.Resolves #2187
build_fileattribute inImageBuildSpec.ImageBuildSpectests and add custom build file testsImageBuildSpec,TargetStageAttrvalidator tonilsince it's an optional value.ImageBuildSpecdocs.go mod tidy.Is this change user facing?
✅
References (if applicable):