feat: image load #2102
Closed
feat: image load #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieubrisse
reviewed
Jan 31, 2024
| ImagerRegistrySpec *image_registry_spec.ImageRegistrySpec | ||
| // Reference to a image file that can be loaded into a backend image | ||
| // This is one of the options to reference a image and this value is optional (i.e. nil) | ||
| ImageLoad *image_load.ImageLoad |
There was a problem hiding this comment.
Is there a usecase for this? I'd imagine users would be either a) specifying an existing Docker image, or b) getting an image through indirect means (either ImageBuildSpec or NixBuildSpec)
mieubrisse
reviewed
Jan 31, 2024
| LoadImageAttr = "image_file_path" | ||
| ) | ||
|
|
||
| func NewImageLoadType() *kurtosis_type_constructor.KurtosisTypeConstructor { |
There was a problem hiding this comment.
Same question as above - makes a lot of sense to me that a KurtosisBackend needs the ability to load images, but do we expect users to be writing Starlark that references an image .tgz?
|
deprecated in favor of Nix builds: #2132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Load container images directly into Kurtosis.
Is this change user facing?
NO