Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KeySymphony Game #4501

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

AdityaP700
Copy link
Contributor

PR Description 📜

The KeySymphony project was developed as a web-based, interactive, and playable piano.
Key Features and Benefits

Accessibility: KeySymphony can be accessed from any device with a web browser, making it convenient for users who do not have access to a physical piano.

Interactive Learning: The virtual piano allows users to play notes using both the mouse and keyboard, creating an engaging and interactive learning experience.

Adjustable Volume: Users can control the sound volume to suit their environment and preferences, enhancing the usability of the tool in different settings.

Customizable Interface: The option to show or hide key labels helps beginners learn the keys and allows advanced users to practice without labels, catering to various skill levels.

Responsive Design: KeySymphony is designed to work seamlessly across different devices and screen sizes, ensuring a consistent user experience.

Fixes # <4499>


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in [CONTRIBUTING GUIDELINE] (https://github.com/kunjgit/GameZone/blob/main/.github/CONTRIBUTING_GUIDELINE.md)
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 13, 2024

Thank you @AdityaP700 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Jun 13, 2024

Here is the PR raised for issue number #4499 you will look into it and if any changes require do let me know,Thanks

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your game lmage in asset folder of the gamezone!!

@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Jun 16, 2024

Concerned Admin @ishita-43 , I have fixed the issues as requested and resolved the conflicts, well kindly go through it and I hope there are no issue as such now . Well if any Persists ,do let me know . Thanks

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

@AdityaP700 resolve merge conflicts

@ishita-43
Copy link
Collaborator

@kunjgit resolved!!

@kunjgit kunjgit merged commit 30b35d7 into kunjgit:main Jun 21, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 21, 2024

Thank you @AdityaP700 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants