Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): run K8S_MIN_VERSION tests on arm64 #11561

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Sep 25, 2024

We have a lot of arm runners and starve amd runners. We have very high trust in our arm support so comparing amd and arm on the same test suite is a little wasteful.

We therefore only run e2e tests on old versions of k8s on arm64 this removes a few entries in the matrix and improve utilization of arm runners

Also move large e2e tests to arm64

Fix #11562

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 25, 2024
We have a lot of arm runners and starve amd runners.
We have very high trust in our arm support so comparing
amd and arm on the same test suite is a little wasteful.

We therefore only run e2e tests on old versions of k8s
on arm64 this removes a few entries in the matrix and
improve utilization of arm runners

Signed-off-by: Charly Molter <[email protected]>
@jijiechen
Copy link
Member

issue: #11562

@slonka slonka marked this pull request as ready for review September 26, 2024 12:33
@slonka slonka requested a review from a team as a code owner September 26, 2024 12:33
@slonka slonka requested review from jijiechen and michaelbeaumont and removed request for a team September 26, 2024 12:33
@jakubdyszkiewicz jakubdyszkiewicz merged commit 3203955 into master Sep 26, 2024
34 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the rune2eOnArm branch September 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ARM64 runners to run some E2E jobs
3 participants