Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-server): skip display-name label for service insight #11508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented Sep 22, 2024

This API would list the SeviceInsight resources with k8s mode, in which the common method GetLabels would be called and supplement the display-name for the Meta.

So, let's just add a mapper function to remove that label in the API-Server component.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- close Skip display name ServiceInsight #9729
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Icarus9913 Icarus9913 requested a review from a team as a code owner September 22, 2024 08:48
@Icarus9913 Icarus9913 requested review from jijiechen and lukidzi and removed request for a team September 22, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip display name ServiceInsight
1 participant