Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from github.com/golang/protobuf/ptypes to google.golang.org/protobuf/types/known #10023

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 21, 2024

migrate from github.com/golang/protobuf/ptypes to google.golang.org/protobuf/types/known

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@mmorel-35 mmorel-35 requested a review from a team as a code owner April 21, 2024 09:02
@mmorel-35 mmorel-35 requested review from jijiechen, bartsmykla and lukidzi and removed request for a team April 21, 2024 09:02
@mmorel-35 mmorel-35 force-pushed the protobuf_v2 branch 2 times, most recently from 0f15108 to a9872b3 Compare April 21, 2024 09:16
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't merge it

go.mod Outdated
@@ -13,7 +13,7 @@ require (
github.com/containernetworking/cni v1.1.2
github.com/containernetworking/plugins v1.4.1
github.com/emicklei/go-restful/v3 v3.12.0
github.com/envoyproxy/go-control-plane v0.12.0
github.com/envoyproxy/go-control-plane v0.12.1-0.20240419124334-0cebb2f428b3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lobkovilya can we do it? I think replace won't work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the replace won't work in this case, I checked locally

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jakub is blocking this so setting a request changes to avoid accidental merge

@lahabana lahabana marked this pull request as draft June 10, 2024 09:21
@mmorel-35 mmorel-35 force-pushed the protobuf_v2 branch 3 times, most recently from a0a42a1 to 5343197 Compare July 22, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants