Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lgtm, approve plugins for etcd-io projects #32725

Merged

Conversation

ArkaSaha30
Copy link
Member

This PR will add lgtm, approve plugins for etcd-io projects which will allow the reviewers to interact with the PRs via chatops to add lgtm, approve labels.

Issue link: etcd-io/etcd#18110

This commit will add `lgtm`, `approve` plugins for
etcd-io projects which will allow the reviewers to
interact with the PRs via chatops to add `lgtm`, `approve`
labels

Signed-off-by: ArkaSaha30 <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Jun 10, 2024
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2024
@ArkaSaha30
Copy link
Member Author

cc @ivanvc @jmhbnz @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jun 10, 2024

Does it mean that PRs on etcd-io/etcd can be automatically merged if both approve and lgtm labels are present?

@ArkaSaha30
Copy link
Member Author

Does it mean that PRs on etcd-io/etcd can be automatically merged if both approve and lgtm labels are present?

Yes, tide will automatically merge iff both approve and lgtm are present.
We can discuss the readiness of etcd for auto-merges as mentioned by @jmhbnz : etcd-io/etcd#18110 (comment)

@jmhbnz
Copy link
Member

jmhbnz commented Jun 10, 2024

/hold
To be discussed if sig-etcd is ready to enable this

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
@ivanvc
Copy link
Member

ivanvc commented Jun 13, 2024

After looking at tide's configuration, I don't think it will run against etcd-io repositories, as it's not listed in

- orgs:
- kubernetes
- kubernetes-client
- kubernetes-csi
- kubernetes-sigs

Would having the LGTM label bring value to the team? It may ease the burden on maintainers while managing the open pull requests.

@ArkaSaha30
Copy link
Member Author

ArkaSaha30 commented Jun 13, 2024

After looking at tide's configuration, I don't think it will run against etcd-io repositories

Correct, we can enable the tide functionality at org or single repo level. If we decide to go with auto-merge, I can add that configuration.

It may ease the burden on maintainers while managing the open pull requests.

Agree, filtering PRs by lgtm approved labels while triaging might be helpful.
But combining tide with it will help maintainers more, we can discuss further on that.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during sig-etcd triage meeting, this is an initial step for enabling tide but will not enable auto merge by itself just the pr labelling.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Jul 4, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@dims
Copy link
Member

dims commented Jul 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, dims, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2fc5321 into kubernetes:master Jul 4, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@ArkaSaha30: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

This PR will add lgtm, approve plugins for etcd-io projects which will allow the reviewers to interact with the PRs via chatops to add lgtm, approve labels.

Issue link: etcd-io/etcd#18110

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants