Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size plugin for etcd-io projects #32723

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add size plugin for etcd-io projects #32723

merged 1 commit into from
Jun 10, 2024

Conversation

ArkaSaha30
Copy link
Member

This PR will add size plugin for etcd-io projects which can label a PR with change length: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L145-L151

Issue link: etcd-io/etcd#18110

@ArkaSaha30
Add size plugin for etcd-io projects
289e729 
This commit will add size plugin for etcd-io projects
which can label a PR with change length: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L145-L151

Signed-off-by: ArkaSaha30 <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Jun 10, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 10, 2024
@ArkaSaha30
Copy link
Member Author

cc @jmhbnz @ahrtr

ahrtr
ahrtr approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@ahrtr
Copy link
Member

ahrtr commented Jun 10, 2024

/lgtm
/approve

MadhavJivrajani
MadhavJivrajani approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 49ee73a into kubernetes:master Jun 10, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@ArkaSaha30: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

This PR will add size plugin for etcd-io projects which can label a PR with change length: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L145-L151

Issue link: etcd-io/etcd#18110

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@ahrtr ahrtr ahrtr approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@MadhavJivrajani MadhavJivrajani

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArkaSaha30 @ahrtr @k8s-ci-robot @MadhavJivrajani