Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /clusterloader2 #2863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Sep 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bumps k8s.io/kubernetes from 1.29.7 to 1.30.4

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2024
@mboersma mboersma force-pushed the clusterloader2/k8s.io/kubernetes-1.30.4 branch from 4ce7605 to 03a8a5d Compare September 5, 2024 22:04
@mboersma
Copy link
Contributor Author

mboersma commented Sep 5, 2024

/retitle [WIP] build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /clusterloader2

Once component-base is updated, this failure begins happening in unit tests for clusterloader2:

?   	k8s.io/perf-tests/clusterloader2/pkg/measurement/common/network-policy	[no test files]
?   	k8s.io/perf-tests/clusterloader2/pkg/measurement/common/probes	[no test files]
/tmp/go-build2416630747/b1424/common.test flag redefined: v
panic: /tmp/go-build2416630747/b1424/common.test flag redefined: v

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0001780e0, {0x2925e40, 0x3e3a170}, {0x29117d8, 0x1}, {0x2594931, 0x22})
	/usr/local/go/src/flag/flag.go:1028 +0x37d
k8s.io/component-base/logs.AddGoFlags.func1(0xc000599180?)
	/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/logs.go:135 +0x130
flag.(*FlagSet).VisitAll(0x0?, 0xc000697dc0)
	/usr/local/go/src/flag/flag.go:458 +0x42
k8s.io/component-base/logs.AddGoFlags(0xc0001780e0, {0x0, 0x0, 0x2d?})
	/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/logs.go:121 +0xa5
k8s.io/component-base/logs/testinit.init.0()
	/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/testinit/testinit.go:31 +0x25
FAIL	k8s.io/perf-tests/clusterloader2/pkg/measurement/common	0.192s

I'm at a loss to work around it. A command-line flag is being registered twice, which panics. According to the component-base code, there is an option to ignore log flag settings, which presumably would avoid this problem. But I can't see how to configure that at package load time.

@k8s-ci-robot k8s-ci-robot changed the title build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /cluster… [WIP] build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /clusterloader2 Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@wojtek-t wojtek-t self-assigned this Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2024
@mboersma mboersma force-pushed the clusterloader2/k8s.io/kubernetes-1.30.4 branch from 03a8a5d to 747aee7 Compare September 16, 2024 17:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mboersma
Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-perf-tests-clusterloader2 747aee7 link true /test pull-perf-tests-clusterloader2
pull-perf-tests-verify-test 747aee7 link true /test pull-perf-tests-verify-test
pull-perf-tests-clusterloader2-kubemark 747aee7 link true /test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants