Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GCP CCM again #15972

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Bump GCP CCM again #15972

merged 1 commit into from
Oct 7, 2023

Conversation

upodroid
Copy link
Member

@justinsb mentioned some CCM bugs have been squashed since the 26.2.4 release.

We'll pin this to a release version soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2023
@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce-slow
/test pull-kops-kubernetes-e2e-cos-gce

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2023
@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce-slow
/test pull-kops-kubernetes-e2e-cos-gce

@hakman hakman requested review from justinsb and removed request for johngmyers September 28, 2023 22:49
@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce-serial

@upodroid
Copy link
Member Author

So the permissions errors have been fixed but the CCM has this bug

kubernetes/cloud-provider-gcp#612

upodroid
upodroid commented Oct 1, 2023
View reviewed changes
pkg/model/components/gcpcloudcontrollermanager.go

// Turn off some controllers if kops-controller is running them
if clusterSpec.IsKopsControllerIPAM() {
changes = append(changes, "-nodeipam", "-route")
changes = append(changes, "-node-ipam-controller", "-node-route-controller")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controllers got renamed recently

 mahamed  REDACTED  ~  $  docker run gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:master --help | grep controllers
      --controllers strings                       A list of controllers to enable. '*' enables all on-by-default controllers, 'foo' enables the controller named 'foo', '-foo' disables the controller named 'foo'.
                                                  All controllers: cloud-node-controller, cloud-node-lifecycle-controller, gkenetworkparamset, node-ipam-controller, node-route-controller, service-lb-controller
                                                  Disabled-by-default controllers: gkenetworkparamset (default [*

@upodroid
Copy link
Member Author

upodroid commented Oct 5, 2023

/test pull-kops-kubernetes-e2e-cos-gce-slow

@upodroid upodroid changed the title [wip] Bump GCP CCM again Bump GCP CCM again Oct 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

This can be merged now, test failures aren't related this change

@hakman
Copy link
Member

hakman commented Oct 6, 2023

This can be merged now, test failures aren't related this change

As long as pull-kops-kubernetes-e2e-cos-gce-slow is "required", the PR cannot be merged.
You can force push to clear the test run.

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

It is optional

/skip pull-kops-kubernetes-e2e-cos-gce-slow

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

Repushed

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 6, 2023 •
edited
Loading

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-cos-gce 07c8520 link true /test pull-kops-kubernetes-e2e-cos-gce
pull-kops-kubernetes-e2e-cos-gce-serial 07c8520 link true /test pull-kops-kubernetes-e2e-cos-gce-serial
pull-kops-kubernetes-e2e-cos-gce-slow c8aef83 link true /test pull-kops-kubernetes-e2e-cos-gce-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Oct 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 24f2354 into kubernetes:master Oct 7, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 7, 2023
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @hakman @k8s-ci-robot