Common flags across VPA components

[omerap12]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

context: #7291 (comment)
We aim to introduce a common flags package to be used across all VPA components (updater, recommender, and admission-controller), consolidating shared configuration options. Currently, arguments are passed using CMD in the Dockerfile, which can lead to improper behavior when users specify custom arguments. By removing this and setting default values under containers.x.args, we eliminate the problematic behavior described above.

Which issue(s) this PR fixes:

Fixes #7291

Special notes for your reviewer:

If approved, we will need to update the VPA chart to include the default arguments (currently specified in the Dockerfile).

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

[k8s-ci-robot]

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[omerap12]

cc @adrianmoisey

[adrianmoisey]

/ok-to-test

[adrianmoisey]

If approved, we will need to update the VPA chart to include the default arguments (currently specified in the Dockerfile).

Is there a way to move this parameter into code?

[omerap12]

If approved, we will need to update the VPA chart to include the default arguments (currently specified in the Dockerfile).

Is there a way to move this parameter into code?

AFAIK no, because those parameter are configured inside the klog package

[adrianmoisey]

If approved, we will need to update the VPA chart to include the default arguments (currently specified in the Dockerfile).

Is there a way to move this parameter into code?

AFAIK no, because those parameter are configured inside the klog package

It seems they're possible to override, something like this seems to work:

klog.InitFlags(nil)
flag.Lookup("v").Usage = "set the log level verbosity (default: 2)"
_ = flag.Set("v", "2")
flag.Parse()

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign jbartosik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment