-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logging statements in recommender:checkpoint,input #7290
base: master
Are you sure you want to change the base?
Refactor logging statements in recommender:checkpoint,input #7290
Conversation
Hi @omerap12. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Omer Aplatony <[email protected]>
b22cf35
to
e06608c
Compare
/ok-to-test |
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/metrics/metrics_source.go
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/metrics/metrics_source.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Moisey <[email protected]>
…source.go Co-authored-by: Adrian Moisey <[email protected]>
…source.go Co-authored-by: Adrian Moisey <[email protected]>
@adrianmoisey fixed, do you want me to rebase? |
Nah, I think it's fine. |
/lgtm |
Hey @kgolab, can you approve this? |
@@ -215,7 +215,7 @@ func (feeder *clusterStateFeeder) InitFromHistoryProvider(historyProvider histor | |||
if err = feeder.clusterState.AddOrUpdateContainer(containerID, nil); err != nil { | |||
klog.Warningf("Failed to add container %+v. Reason: %+v", containerID, err) | |||
} | |||
klog.V(4).Infof("Adding %d samples for container %v", len(sampleList), containerID) | |||
klog.V(4).InfoS("Adding samples for container", "samples", len(sampleList), "container", containerID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
klog.V(4).InfoS("Adding samples for container", "samples", len(sampleList), "container", containerID) | |
klog.V(4).InfoS("Adding samples for container", "sampleCount", len(sampleList), "container", containerID) |
} | ||
for _, checkpoint := range checkpointList.Items { | ||
|
||
klog.V(3).Infof("Loading VPA %s/%s checkpoint for %s", checkpoint.ObjectMeta.Namespace, checkpoint.Spec.VPAObjectName, checkpoint.Spec.ContainerName) | ||
klog.V(3).InfoS("Loading VPA checkpoint", "namespace", checkpoint.ObjectMeta.Namespace, "VPA", checkpoint.Spec.VPAObjectName, "container", checkpoint.Spec.ContainerName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consistency with other log lines where it's lowercase vpa
klog.V(3).InfoS("Loading VPA checkpoint", "namespace", checkpoint.ObjectMeta.Namespace, "VPA", checkpoint.Spec.VPAObjectName, "container", checkpoint.Spec.ContainerName) | |
klog.V(3).InfoS("Loading VPA checkpoint", "namespace", checkpoint.ObjectMeta.Namespace, "vpa", checkpoint.Spec.VPAObjectName, "container", checkpoint.Spec.ContainerName) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To align the logging with the best practices and guidelines established within the Kubernetes ecosystem.
Which issue(s) this PR fixes:
As part of #6905, I'm splitting this into multiple PRs rather than submitting a single large PR.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: