Skip to content

Commit

Permalink
Merge pull request #517 from marquiz/backports/helm
Browse files Browse the repository at this point in the history
backport-0.8: helm: add extraLabelNs master flag
  • Loading branch information
k8s-ci-robot authored May 17, 2021
2 parents f14d193 + 9fc309a commit e791352
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deployment/node-feature-discovery/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ keywords:
- feature-detection
- node-labels
type: application
version: 0.1.1
version: 0.1.2
3 changes: 3 additions & 0 deletions deployment/node-feature-discovery/templates/master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ spec:
{{- if .Values.master.instance | empty | not }}
- "--instance={{ .Values.master.instance }}"
{{- end }}
{{- if .Values.master.extraLabelNs | empty | not }}
- "--extra-label-ns={{- join "," .Values.master.extraLabelNs }}"
{{- end }}
## Enable TLS authentication
## The example below assumes having the root certificate named ca.crt stored in
## a ConfigMap named nfd-ca-cert, and, the TLS authentication credentials stored
Expand Down
4 changes: 3 additions & 1 deletion deployment/node-feature-discovery/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ image:
# tag, if defined will use the given image tag, else Chart.AppVersion will be used
# tag
imagePullSecrets: []

serviceAccount:
# Specifies whether a service account should be created
create: true
Expand All @@ -20,6 +20,8 @@ fullnameOverride: ""

master:
instance:
extraLabelNs: []

replicaCount: 1

podSecurityContext: {}
Expand Down
1 change: 1 addition & 0 deletions docs/get-started/deployment-and-usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ We have introduced the following Chart parameters.
| ---- | ---- | ------- | ----------- |
| `master.*` | dict | | NFD master deployment configuration |
| `master.instance` | string | | Instance name. Used to separate annotation namespaces for multiple parallel deployments |
| `master.extraLabelNs` | array | [] | List of allowed extra label namespaces |
| `master.replicaCount` | integer | 1 | Number of desired pods. This is a pointer to distinguish between explicit zero and not specified |
| `master.podSecurityContext` | dict | {} | SecurityContext holds pod-level security attributes and common container settings |
| `master.service.type` | string | ClusterIP | NFD master service type |
Expand Down

0 comments on commit e791352

Please sign in to comment.