-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add bad-credentials exception for install script #5756
base: master
Are you sure you want to change the base?
chore: add bad-credentials exception for install script #5756
Conversation
|
Welcome @viniciusdc! |
Hi @viniciusdc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi there, @viniciusdc! Could you please sign the CNCF CLA? We cannot accept contributions unless you sign it. Instructions on how to do so can be found here: https://kubernetes.io/docs/contribute/new-content/#sign-the-cla Can you also please update your commit messages to follow the Conventional Commit standard, as described here? Thanks in advance! |
Hi @stormqueen1990, Thanks for the quick follow-up. I just got the approval for the CLA. Thanks for pointing out the docs for the commit standard; I went to look for something like that before opening the PR but didn't find it. I will amend it later today. |
55b90a4
to
dbe71d8
Compare
install_kustomize.sh
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* fix typo at closing if statement
f4cd01e
to
3872752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viniciusdc!
/lgtm
/assign @varshaprasad96
for maintainer review
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chansuke, viniciusdc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, @chansuke @stormqueen1990, for the initial review! Pinging @varshaprasad96 for final approval. |
closes #5755
Improved error handling for cases where the GITHUB_TOKEN is invalid or expired. The
install_kustomize.sh
script now provides a clear message when authentication fails due to token issues.