Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bad-credentials exception for install script #5756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viniciusdc
Copy link

closes #5755

Improved error handling for cases where the GITHUB_TOKEN is invalid or expired. The install_kustomize.sh script now provides a clear message when authentication fails due to token issues.

Copy link

linux-foundation-easycla bot commented Sep 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: viniciusdc / name: Vinicius D. Cerutti (3872752)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @viniciusdc!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @viniciusdc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2024
@stormqueen1990
Copy link
Member

Hi there, @viniciusdc!

Could you please sign the CNCF CLA? We cannot accept contributions unless you sign it.

Instructions on how to do so can be found here: https://kubernetes.io/docs/contribute/new-content/#sign-the-cla

Can you also please update your commit messages to follow the Conventional Commit standard, as described here?

Thanks in advance!

@viniciusdc
Copy link
Author

viniciusdc commented Sep 4, 2024

Hi @stormqueen1990, Thanks for the quick follow-up. I just got the approval for the CLA. Thanks for pointing out the docs for the commit standard; I went to look for something like that before opening the PR but didn't find it. I will amend it later today.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 4, 2024
@viniciusdc viniciusdc changed the title Enhance GITHUB_TOKEN error handling in install_kustomize.sh chore: add bad-credentials exception for install script Sep 4, 2024
hack/install_kustomize.sh Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viniciusdc!

/lgtm
/assign @varshaprasad96
for maintainer review

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke, viniciusdc
Once this PR has been reviewed and has the lgtm label, please ask for approval from varshaprasad96. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@viniciusdc
Copy link
Author

Thanks, @chansuke @stormqueen1990, for the initial review! Pinging @varshaprasad96 for final approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling Authentication Errors in install_kustomize.sh`
5 participants