Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update KIND to v0.20.0 #8908

Merged
merged 1 commit into from
Jun 23, 2023
Merged

🌱 Update KIND to v0.20.0 #8908

merged 1 commit into from
Jun 23, 2023

Conversation

killianmuldoon
Copy link
Contributor

Update KIND to v0.20.0.

Release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0

There was some changes in the kindest/node build process in this release which caused additional work to adopt it. See more under issue #8788.

Fixes #8788

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2023
killianmuldoon
killianmuldoon commented Jun 23, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The CAPI K8s upgrade tests are currently failing because we are always building the latest version of the image with KIND 0.19.0, but trying to run them with KIND_MODE=v0.20.0 due to the behaviour of the KIND mapper.

I'm hopeful we won't have the same kinds of build issues in the future, but there's an order of operations problem with those tests combined with the KIND_MAPPER.

An possible solution (upstream in KIND) would be to add a label to the images with the KIND build version, not sure if that would be accepted upstream though.

@killianmuldoon
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
  • /test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@killianmuldoon
Update KIND to v0.20.0
db72647 
Signed-off-by: killianmuldoon <[email protected]>
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@sbueringer
Copy link
Member

Change sounds reasonable to me, especially to get back to green.

/lgtm
/approve

/hold
for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ca94f06de5fefb569b25d2e2909e67b1172143b

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
chrischdi
chrischdi reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@killianmuldoon
Copy link
Contributor Author

/hold remove

e2e now passing

@killianmuldoon
Copy link
Contributor Author

/hold cancel

🙃

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 45dbbb7 into kubernetes-sigs:main Jun 23, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 23, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jun 26, 2023
Merged
@killianmuldoon
Copy link
Contributor Author

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 27, 2023
This was referenced Jul 7, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Update kind to v0.20.0
4 participants
@killianmuldoon @k8s-ci-robot @sbueringer @chrischdi