-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add MachinePool Machine support in clusterctl discovery #8836
Conversation
/assign @fabriziopandini I've separated the clusterctl changes out from the main MPM PR. I think this change should be pretty straightforward to review. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR!
overall lgtm, only one small improvement from my side + if possible, let's add a test case into Test_Discovery
@ykakarap PTAL
@ykakarap Any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach looks good. Can you please add some unit tests for this under Test_Discovery?
@ykakarap I've added some tests, will rebase today as well. |
67ecf39
to
139cdd2
Compare
/retest |
@Jont828 it seems that some tests are broken after the changes to the fake objects in this PR |
@fabriziopandini Should be fixed (waiting on test results). |
/lgtm |
LGTM label has been added. Git tree hash: a529dcee344eab00a2d9b593ab0848e5ce30dd9b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Allow clusterctl discovery to find MachinePool Machines and associated infraMachines.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4063