Merge pull request #10214 from Nordix/revert-ginkgo-deprec/adil

🐛 Reverting ginkgo.show-node-events to ginkgo.progress
kubernetes-sigs · Feb 29, 2024 · 93dc0ca · 93dc0ca
2 parents 36a54ad + 35c2606
commit 93dc0ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/test/e2e/data/kubetest/conformance.yaml b/test/e2e/data/kubetest/conformance.yaml
@@ -1,7 +1,10 @@
 ginkgo.focus: \[Conformance\]
 ginkgo.skip: \[Serial\]
 disable-log-dump: true
-ginkgo.show-node-events: true
+# ginkgo.progress flag is deprecated but its still used in
+# k8s versions <= v1.26, we have to keep it as long as we
+# support these versions.
+ginkgo.progress: true
 ginkgo.slow-spec-threshold: 120s
 ginkgo.flake-attempts: 3
 ginkgo.trace: true

diff --git a/test/e2e/data/kubetest/dualstack.yaml b/test/e2e/data/kubetest/dualstack.yaml
@@ -1,7 +1,10 @@
 ginkgo.focus: \[Feature\:IPv6DualStack\]
 ginkgo.skip: \[Feature\:SCTPConnectivity\]
 disable-log-dump: true
-ginkgo.show-node-events: true
+# ginkgo.progress flag is deprecated but its still used when
+# we run kubetest on K8s versions <= v1.26, we have to keep it
+# as long as we support these versions.
+ginkgo.progress: true
 ginkgo.slow-spec-threshold: 120s
 ginkgo.flake-attempts: 3
 ginkgo.trace: true