Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
tsuzu committed Sep 29, 2024
1 parent 56b5af9 commit 33bc162
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion config/metrics/templates/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Metrics

**Disclamer**: This is a temporary workaround. The long-term goal is to generate metric configuration from API type markers.
**Disclaimer**: This is a temporary workaround. The long-term goal is to generate metric configuration from API type markers.

The make target `generate-metrics-config` is used to generate a single file which contains the Cluster API specific custom resource configuration for kube-state-metrics.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ maintainers of providers and consumers of our Go API.

### Suggested changes for providers

- The Errors package was created when capi provider implementation was running as machineActuators that needed to vendor core capi to function. There is no usage recommendations today and its value is questionable since we moved to CRDs that inter-operate mostly via conditions. Instead we plan to drop the dedicated semantic for terminal failure and keep improving Machine lifecycle signal through conditions. Therefore the Errors package [has been deprecated in v1.8](https://github.com/kubernetes-sigs/cluster-api/issues/10784). It's recommented to remove any usage of the currently exported variables.
- The Errors package was created when capi provider implementation was running as machineActuators that needed to vendor core capi to function. There is no usage recommendations today and its value is questionable since we moved to CRDs that inter-operate mostly via conditions. Instead we plan to drop the dedicated semantic for terminal failure and keep improving Machine lifecycle signal through conditions. Therefore the Errors package [has been deprecated in v1.8](https://github.com/kubernetes-sigs/cluster-api/issues/10784). It's recommended to remove any usage of the currently exported variables.
2 changes: 1 addition & 1 deletion docs/book/src/reference/api/metadata-propagation.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Top-level labels that meet a specific cretria are propagated to the Node labels
- `.labels.[label-meets-criteria]` => `Node.labels`
- `.annotations` => Not propagated.

Label should meet one of the following criterias to propagate to Node:
Label should meet one of the following criteria to propagate to Node:
- Has `node-role.kubernetes.io` as prefix.
- Belongs to `node-restriction.kubernetes.io` domain.
- Belongs to `node.cluster.x-k8s.io` domain.

0 comments on commit 33bc162

Please sign in to comment.