feat: allow to don't use helm hooks for CSIDriver creation

[woehrl01]

Is this a bug fix or adding new feature?

Fixes #765
Fixes #325

What is this PR about? / Why do we need it?

According to how external tools are executing the hooks, there can be a possibility that the CSIDriver gets deleted but never created. This PR adds a flag, so that the CSIDriver can be added without using helm hooks. This has the benefit that the Csidriver doesn't gets constantly recreated on each update of the chart (which doesn't make scene, imho)

Adds a flag useHelmHooksForCSIDriver to Values, which can be used to disable usage of hooks.

Currently, does not change the default behaviour to not impact existing users.

What testing is done?

Verified that the sources does not show up as deleted

[k8s-ci-robot]

Welcome @woehrl01!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @woehrl01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[clarifai-fmarceau]

We're affected by this issue as well, thank you @woehrl01 for making a PR. @justinsb @mskanth972 is there any chance that one of you can review this soon !?

[Ashley-wenyizha]

/ok-to-test

[yuriydzobak]

Hi @mskanth972 @jqmichael
Please, Could you review/approve the PR?
Thank you in advance

[yuriydzobak]

Hi @mskanth972 @jqmichael Please, Could you review/approve the PR? Thank you in advance

ping

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[woehrl01]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[woehrl01]

/remove-lifecycle

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[z0rc]

/remove-lifecycle rotten

[josh-ferrell]

@nckturner Do you know if this can be assigned to someone to take a look at it?

[chrissnell]

Can somebody take a look at this? This issue caused a huge outage for us and we need this feature.

[mskanth972]

/lgtm

[mskanth972]

@woehrl01 can you get EasyCLA authorization?

[woehrl01]

@mskanth972 sure, I just don't know which link to click, according to the wiki there should be one on the pr.

[chrissnell]

@mskanth972 looks like the EasyCLA bot is not running here

[woehrl01]

/check-cla

[woehrl01]

@mskanth972 Looks like a rebase + checking the cla was enough, can you please have another look? Thanks!

[chrissnell]

@mskanth972 tests are failing but they don't appear to be related to @woehrl01 's work:

43.19 	cargo is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64
43.19 	rust is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64

[mskanth972]

We have the fix for it here(aws/efs-utils#237) which is merged but needs to release a new tag/release for efs-utils so that driver can pick the change. We have a plan of bundling one more feature request with this new release, so the reason for delay. The ECD for new driver version with this fix will be 09/20 and for Addons will be 09/27.

[chrissnell]

We have the fix for it here(aws/efs-utils#237) which is merged but needs to release a new tag/release for efs-utils so that driver can pick the change. We have a plan of bundling one more feature request with this new release, so the reason for delay. The ECD for new driver version with this fix will be 09/20 and for Addons will be 09/27.

Are you referring to the fix for the automated tests, or @woehrl01 's fix for the Helm chart hooks? The hooks issue is the big one for my company, obviously. Can we expect a fix for the hooks on 9/27?

[mskanth972]

We have the fix for it here(aws/efs-utils#237) which is merged but needs to release a new tag/release for efs-utils so that driver can pick the change. We have a plan of bundling one more feature request with this new release, so the reason for delay. The ECD for new driver version with this fix will be 09/20 and for Addons will be 09/27.

Are you referring to the fix for the automated tests, or @woehrl01 's fix for the Helm chart hooks? The hooks issue is the big one for my company, obviously. Can we expect a fix for the hooks on 9/27?

The ECD is same for all the PRs which are waiting on release(build and hooks issue) i.e., 9/27 Addons.

[mskanth972]

/retest

[woehrl01]

Failing test is not related to my changes.

[jrakas-dev]

@woehrl01, could you please rebase your PR to re-trigger the tests? The fix for build issue has been resolved.

[mskanth972]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, woehrl01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mskanth972]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment