updates go and k8s packages and removes SSH from CI as it is unnecessary and introduces a potential flake point. #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
mskanth972
changed the title
mskanth972
changed the title
k8s-ci-robot
added
the
needs-rebase
SSH access is completely unnecessary for CI and introduces a potential flake point.
k8s-ci-robot
removed
the
needs-rebase
| @@ -68,14 +63,14 @@ function eksctl_create_cluster() { | |||
|
|
|||
| if [[ "$WINDOWS" == true ]]; then | |||
There was a problem hiding this comment.
Nit : We do not support windows, but this is a day one issue, might want to remove this in a separate PR later
|
/lgtm |
k8s-ci-robot
added
the
lgtm
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
This PR updates go and k8s packages and removes SSH from CI
Referred EBS CSI driver PRs for changes in testing environment which is required by k8's update.
kubernetes-sigs/aws-ebs-csi-driver#1521
kubernetes-sigs/aws-ebs-csi-driver#1566
What testing is done?