AlphaChest update #18
Conversation
I fixed some stuff.
|
You haven't used the same indent style as the rest of the plugin. This makes for legibility problems, not least of which is in the output of |
|
Well I'd highly recommend looking over git diff, and updating the plugin with some aspects of it. I removed some things not being used on my server, and sort of forgot. Also there are a couple unused classes I was going to implement. Either way you should probably adopt the completablefutures, concurrenthashmap, and event-based loading. Losing 800 ticks on average from a single plugin's save event makes it unusable. Loading every single chest in the directory onEnable is crazytown. The save task took ~4k ms, and now takes 5ms, so it's pretty dramatic. Also the formatting is a simple refactor :P. Maybe don't merge the PR, but you should certainly adopt some of the ideas |
I fixed some stuff.