Fix typos #739
Open
Fix typos #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should all be one commit |
Yeap, the idea is to have it each one just for quick review, and to squash it before merge (GitHub interface lets you do it before merge). Anyway, I update in one squash! |
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
f9ece23
to
eda6a19
Compare
|
Rebased the patch on latest commit. |
|
New update. Added fix for: "reentrency", "durabilty", "definites", "ascestor" |
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
ca463c4
to
f2c4fab
Compare
|
Updated with latest commits. |
|
Added a new fix for "sentinal" |
|
Updated to latest commits |
Gelma
force-pushed
the
FixTypo
branch
2 times, most recently
from
0374ecd
to
15beeef
Compare
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
98cf038
to
2d5e650
Compare
A series posted previously moved all of the `struct xattr_handler` tables to .rodata for each filesystem [1]. However, this appears to have been done shortly before bcachefs was merged, so bcachefs was missed at that time. Link: https://lkml.kernel.org/r/[email protected] [1] Cc: Wedson Almeida Filho <[email protected]> Signed-off-by: Thomas Bertschinger <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
…hefs coding style page Specifically, fixed spelling of "commit" and pluralization of last sentence. Signed-off-by: Dennis Lam <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
vmalloc doesn't correctly respect gfp flags - gfp flags aren't used for pte allocation, so doing vmalloc/kvmalloc allocations with reclaim unsafe locks is a potential deadlock. Note that we also want to use PF_MEMALLOC_NORECLAIM, not PF_MEMALLOC_NOFS, because when we're doing allocations with btree locks held we have a fallback available - drop locks and do a normal GFP_KERNEL allocation. We don't want to be invoking reclaim with btree locks held at all, since these are big shared locks and overalll system performance is sensitive to hold times. Signed-off-by: Kent Overstreet <[email protected]>
d2inventory
reviewed
Sep 23, 2024
fs/bcachefs/btree_gc.c
Outdated
There was a problem hiding this comment.
This should be "idempotent" not "independent"
There was a problem hiding this comment.
Thanks a lot @d2inventory !!!
I'm going to fix this right now!
Signed-off-by: Andrea Gelmini <[email protected]>
koverstreet
force-pushed
the
master
branch
6 times, most recently
from
6b07af7
to
1166d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, thanks a lot for your work.
Here's a stupid patch about stupid detalis.
Thanks a lot,
Gelma