Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation to test on click #318

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Rattlehead931
Copy link
Contributor

The navigation to tests has been broken for a long time and it has been hampering my productivity a lot. I do not understand whats the point of navigating to an arbitrary white space character that can be anywhere between two tests.

This is just a simple fix to alleviate that issue. It will navigate to the next non white space character between two tests. Which is a lot better than the current behavior.

Previous behavior: https://jam.dev/c/fa4b7672-a472-4f32-991f-33cd49c79849
Behavior After these changes: https://jam.dev/c/b0551b1b-5d91-4bbb-9d0a-c8e6cc8f843a

Please review this PR. Or suggest me on what tests should I add.

@sksamuel sksamuel merged commit b2aaf31 into kotest:master Sep 30, 2024
6 checks passed
@sksamuel
Copy link
Member

awesome thanks, will release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants