Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil point exception when create cluster #218

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: nil point exception when create cluster #218

merged 1 commit into from
Nov 10, 2023

Conversation

ONE7live
Copy link
Member

@ONE7live ONE7live commented Nov 9, 2023

What type of PR is this?

/kind bug

What does this PR do?

support cluster join multi-module install, and cluster join success.

Which issue(s) does this PR fix?

Fixes #217

Special notes for your reviewer:

/cc @yuleichun-striving

Does this PR introduce a user-facing change?


@yuleichun-striving
Copy link
Contributor

/lgtm

@wuyingjun-lucky
Copy link
Member

/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ONE7live, wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit 649d784 into kosmos-io:main Nov 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a problem with using kosmosctl to deploy only a single service
4 participants