This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Example petstore #216
Merged
Example petstore #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornicameister
commented
Jan 22, 2020
examples/petstore/api/__init__.py
Outdated
|
|
||
|
|
||
| async def list_pets( | ||
| tags: t.Optional[list] = None, |
There was a problem hiding this comment.
it actually should be t.Optional[t.List[str]] but "axion" decided that it should be t.Optional[list] which seems dumb.
Will create issue for that.
kornicameister
commented
Jan 22, 2020
examples/mypy.ini
Outdated
| @@ -0,0 +1,5 @@ | |||
| [mypy] | |||
| plugins = axion.mypy, pydantic.mypy | |||
There was a problem hiding this comment.
Yeah, it uses the plugin which is being developed on top of example to see how much of handler runtime analysis can be replaced with static type checking.
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 26 26
Lines 1383 1383
=======================================
Hits 1380 1380
Misses 3 3Continue to review full report at Codecov.
|
This was referenced Jan 22, 2020
Provides a foundation for a first actual example of what `axion` is capable of doing. This example will intentionally be left unfinished to facilitate `mypy` plugin development and bug hunting.
kornicameister
force-pushed
the
example_petstore
branch
from
bf42e4d
to
50e4408
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a basic Petstore example.
Needed-By: #228