Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set chroma_sample_position only for YUV 4:2:0 #41

Merged

Commits on Sep 9, 2021

  1. Set chroma_sample_position only for YUV 4:2:0

    The chroma_sample_position syntax element is only used for YUV 4:2:0 in
    the AV1 bitstream. So set chroma_sample_position to
    ChromaSamplePosition::Unknown for all other YUV formats, including
    monochrome (YUV 4:0:0).
    
    Note: For still images, the most common chroma sample position in
    practice is the "center" position. Unfortunately the AV1 specification
    does not have a value for the "center" chroma sample position. See
    AOMediaCodec/av1-avif#88 and
    AOMediaCodec/av1-spec#308. This pull request
    preserves the ChromaSamplePosition::Colocated value that is currently
    used, but it is likely to be incorrect when YUV 4:2:0 is supported.
    wantehchang committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    018afc2 View commit details
    Browse the repository at this point in the history