Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add IBM VPC contract default transformer #35

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: Add IBM VPC contract default transformer #35

wants to merge 32 commits into from

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Sep 7, 2022

Signed-off-by: Mehant Kammakomati [email protected]

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Sep 7, 2022
@kmehant kmehant force-pushed the feat-vpc-contract-generator branch 2 times, most recently from f2170cc to efbb92d Compare September 7, 2022 14:54
@kmehant
Copy link
Member Author

kmehant commented Sep 8, 2022

do not merge
Thank you

@ashokponkumar ashokponkumar added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2022
@kmehant kmehant force-pushed the feat-vpc-contract-generator branch 2 times, most recently from 566835c to 3246216 Compare September 13, 2022 09:55
@kmehant kmehant force-pushed the feat-vpc-contract-generator branch 3 times, most recently from 403413f to 7ad9897 Compare September 16, 2022 16:10
ashokponkumar
ashokponkumar requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does having two template, one for encrypted and another for non encrypted necessiate them to be in sync.

If so, is there a way to remove this requirement.

custom-vpc-contract-generator/vpccontractgenerator.star Outdated
# Creates IBM VPC contract file
def transform(new_artifacts, old_artifacts):
ibmHyperProtectCert = """
-----BEGIN CERTIFICATE-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to move this to a file and read from the file.

@kmehant kmehant force-pushed the feat-vpc-contract-generator branch 2 times, most recently from a07fa12 to 1f7d91c Compare September 22, 2022 15:26
@kmehant kmehant force-pushed the feat-vpc-contract-generator branch from 9d54ea9 to d3f24e1 Compare March 8, 2023 11:24
@kmehant
feat: transformer for IBM VPC contract generation
6d61fd2 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: questions
80419d5 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: change how template source is added to path mappings
0d527b8 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: images is seperate from auths
dbf37ec 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: add dest path and use updated section name for ivokedByDefaultTr…
f409e40 
…ansformer. add env and workload templates

Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: generate encrypted contract
11a8af2 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: add cert to transformer
1f53841 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: pull certificate from assets folder
00d6458 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: change assets to resources
6a24b20 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: 2 transformers to produce vpc artifacts
25f3d99 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: take docker compose file path as input and produce digest
db3b59f 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: update the archival funtion with compression
bc89b58 
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant and others added 10 commits March 16, 2023 20:04
@kmehant
fix: use snake case for starlark custom functions
83e308d 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: input docker compose as text
e737776 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: send file path for archival
daef2c2 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: broken input while using config option
a4be356 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: change choice to enabled
c9d8a8d 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: bugs and generate selective config files
72714fb 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: solve bugs reported
e48056d 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
fix: add dct and rhs
373c829 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: updates and fixes on custom transformer
1514fc7 
Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant
feat: use container based transformer for encryption part of the cont…
0b88d7f 
…ract generation

Signed-off-by: Mehant Kammakomati <[email protected]>
@kmehant kmehant force-pushed the feat-vpc-contract-generator branch from d3f24e1 to 0b88d7f Compare March 16, 2023 14:35
kmehant and others added 10 commits March 21, 2023 17:06
@kmehant
fix: use MultiLineInput instead of MultiLine
111900e 
Signed-off-by: Mehant Kammakomati <[email protected]>
@Sativarsainath-26
Volume Section creation fix (#1)
b9d30c3 
* Volume Section creation fix

* Updating latest Fixes for contract creation
@HarikrishnanBalagopal
feat: add contract signing ability (#2)
5dda99e 
Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
fix: the template for encrypted contract
3491532 
Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
fix: sign the contract only if both the workload and env section is p…
19f1fb3 
…resent

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
feat: detect the docker-compose file/dir from the source code directo…
0299ab7 
…ry (#3)

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
fix: support both .yaml and .yml extensions
09cdc71 
Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
chore: remove debug message that outputs binary
301dd53 
Signed-off-by: Harikrishnan Balagopal <[email protected]>
@HarikrishnanBalagopal
fix: the signature was not valid base64 because we remove the last ch…
194e9ac 
…aracter (padding)

Signed-off-by: Harikrishnan Balagopal <[email protected]>
@Sativarsainath-26
updating code with latest features (#4)
d30cb15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarikrishnanBalagopal HarikrishnanBalagopal Awaiting requested review from HarikrishnanBalagopal

@ashokponkumar ashokponkumar Awaiting requested review from ashokponkumar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmehant @ashokponkumar @Sativarsainath-26 @HarikrishnanBalagopal