Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include podman resource requirements for mac #95

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

eemcmullan
Copy link
Collaborator

Closes #61
Closes #91

README.md Outdated
Due to a known issue with limited number of open files in mounted volumes on MacOS, increase podman resources:

```sh
podman machine set <vm_name> --cpus 4 --memory 8192
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 4 Gigs might be reasonable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I don't believe the memory/cpu has a relationship to the number of open files.
Let's update this so we don't confuse ourselves/others in future.

The memory I believe will stop analysis of large applications, but it won't help for the open file limit

As to 4GB, that sounds reasonable, I ran with 8GB out of caution, i think @hhpatel14 is using 4GB.

Copy link
Member

@jwmatthews jwmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few updates to consider.

README.md Outdated
Due to a known issue with limited number of open files in mounted volumes on MacOS, increase podman resources:

```sh
podman machine set <vm_name> --cpus 4 --memory 8192
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I don't believe the memory/cpu has a relationship to the number of open files.
Let's update this so we don't confuse ourselves/others in future.

The memory I believe will stop analysis of large applications, but it won't help for the open file limit

As to 4GB, that sounds reasonable, I ran with 8GB out of caution, i think @hhpatel14 is using 4GB.

README.md Outdated
podman machine set <vm_name> --cpus 4 --memory 8192
```

Prior to starting your podman machine, run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add the info about Mac and limiting the number of open files on a volume mount and please be sure to link to this known issue to help others to be fully aware: containers/podman#16106 (comment)

Note, I think this command needs to be run after every reboot, i.e. I don't think ulimit is persisted.
Worth calling this out so the end user is aware, they may want to put the ulimit in their shell login script

Copy link
Member

@jwmatthews jwmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eemcmullan

@eemcmullan eemcmullan merged commit 2323b77 into konveyor:main Oct 23, 2023
2 checks passed
eemcmullan added a commit to eemcmullan/kantra that referenced this pull request Nov 17, 2023
@eemcmullan eemcmullan deleted the podman-readme branch January 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants