🐛 add missing support for label selector #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
approved these changes
Oct 19, 2023
pranavgaikwad
requested changes
Oct 20, 2023
cmd/analyze.go
Outdated
| @@ -136,6 +137,7 @@ func NewAnalyzeCmd(log logr.Logger) *cobra.Command { | |||
| analyzeCommand.Flags().BoolVar(&analyzeCmd.listTargets, "list-targets", false, "list rules for available migration targets") | |||
| analyzeCommand.Flags().StringArrayVarP(&analyzeCmd.sources, "source", "s", []string{}, "source technology to consider for analysis") | |||
| analyzeCommand.Flags().StringArrayVarP(&analyzeCmd.targets, "target", "t", []string{}, "target technology to consider for analysis") | |||
| analyzeCommand.Flags().StringVarP(&analyzeCmd.labelSelector, "label-selector", "l", "", "run rules based on specified label") | |||
There was a problem hiding this comment.
run rules based on specified label selector expression
cmd/analyze.go
Outdated
| labelSelector := a.getLabelSelector() | ||
| if labelSelector != "" { | ||
| args = append(args, fmt.Sprintf("--label-selector=%s", labelSelector)) | ||
| if a.labelSelector != "" { |
There was a problem hiding this comment.
when label selector is not specified, it doesn't look like we are using sources / targets labels
Signed-off-by: David Zager <[email protected]>
djzager
force-pushed
the
labelSelector
branch
from
40f4663
to
a566b64
Compare
pranavgaikwad
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33