MTA-1309: Do not allow input and output dirs to be the same for transform rules #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrugaro
reviewed
Sep 22, 2023
| @@ -77,6 +77,11 @@ func (w *windupShimCommand) Validate() error { | |||
| if w.input == nil || len(w.input) == 0 { | |||
| return fmt.Errorf("input for rule file or directory must not be empty") | |||
| } | |||
| for _, r := range w.input { | |||
| if r == w.output { | |||
| return fmt.Errorf("input rule directory and output directory must be different") | |||
There was a problem hiding this comment.
question: Will this error be triggered also if the paths are different but just by slashes?
Example:
- input: /path/to/folder/ (Slash at the end)
- output: /path/to/folder (No slash at the end)
Or
- input: /path\to\folder (backslashes)
- output: /path/to/folder
I'm new to Go so I don't know if the paths are being sanitized before this condition.
Thanks!
There was a problem hiding this comment.
@abrugaro great point, paths indeed need to be cleaned before comparing, thank you
|
@eemcmullan need to update line numbers in demo-output because of konveyor/analyzer-lsp@dca2d15 |
pranavgaikwad
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Clean paths, and increment line numbers by 1 in demo-output for
kantra/test-data/analysis-output.yaml
Line 1440 in 9e3f539
kantra/test-data/analysis-output.yaml
Line 1472 in 9e3f539
pranavgaikwad
approved these changes
Sep 26, 2023
Signed-off-by: Emily McMullan <[email protected]>
Signed-off-by: Emily McMullan <[email protected]>
dymurray
pushed a commit
that referenced
this pull request
Oct 6, 2023
* MTA-1309: Do not allow input and output dirs to be the same for transform rules (#73) * do not allow input and output dirs to be the same for transform Signed-off-by: Emily McMullan <[email protected]> * update filepath clean and test output Signed-off-by: Emily McMullan <[email protected]> --------- Signed-off-by: Emily McMullan <[email protected]> * display link to static report (#80) Signed-off-by: Emily McMullan <[email protected]> --------- Signed-off-by: Emily McMullan <[email protected]> Co-authored-by: Emily McMullan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1309