Skip to content

Commit

Permalink
wrong version number
Browse files Browse the repository at this point in the history
I know that release is already done, but later if we need to replace it and search is going to get a little bit more difficult.
  • Loading branch information
neo22s committed May 20, 2014
1 parent 06c8242 commit 56e452c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions classes/Kohana/Core.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
class Kohana_Core {

// Release version and codename
const VERSION = '3.3.1';
const CODENAME = 'peregrinus';
const VERSION = '3.3.2';
const CODENAME = 'dryocopus';

// Common environment type constants for consistency and convenience
const PRODUCTION = 10;
Expand Down

5 comments on commit 56e452c

@neo22s
Copy link
Member Author

@neo22s neo22s commented on 56e452c May 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have not committed directly here my bad.

@kemo
Copy link
Member

@kemo kemo commented on 56e452c May 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this?

@neo22s
Copy link
Member Author

@neo22s neo22s commented on 56e452c May 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? :S it's the wrong number or codename?

The version and codename was wrong, I have changed instead with a pull in a commit, my bad. But is already done. I don't think is worth, 1st discuss it 2nd change it since it's fine. Thanks.

@samwilson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the best fix for this is to update to 3.3.3. This commit doesn't really matter (I don't see any need to revert, certainly), but there is a problem with the tagged v3.3.2 having the wrong version number. Not a big problem — it's just a bug that can be corrected with a (backwards-compatible) patch-level version update.

@neo22s
Copy link
Member Author

@neo22s neo22s commented on 56e452c May 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best fix for this is to update to 3.3.3

Agree ;)

Please sign in to comment.