Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for losing data during rotation of device #33

Open
wants to merge 1 commit into
base: rotation
Choose a base branch
from

Conversation

Naitim
Copy link
Contributor

@Naitim Naitim commented Dec 31, 2021

Hello again Knirirr

I was using the BeeCount app and I noticed another activity that can lead to data loss. When the user goes to edit the count settings for an item as can be seen here: https://ibb.co/N2LHbNJ

If the screen focus goes to another app or activity(for example if an incoming call forces the user to go into the phone app), or if the user rotates the phone and changes the app to landscape mode, the user will lose any data they had put into this page as can be seen here: https://ibb.co/C09QQCf

I have used savedInstanceState to automatically save the data in such cases and restore the data when the user returns to the BeeCount app(and hence the activity) or after the phone is rotated. Therefore, the user does not have to fill in the data again thus improving the user experience.

I have tested out the feature to ensure it works.

If you have any questions or if you would like me to change anything, please do not hesitate to let me know!

Thank you for your time,
Tim

@knirirr
Copy link
Owner

knirirr commented Dec 31, 2021

Thanks for getting in touch. Would you mind changing this PR to merge into my "rotation" branch, please? I will then take a look when I get a moment.

@Naitim Naitim changed the base branch from master to rotation January 1, 2022 02:44
@Naitim
Copy link
Contributor Author

Naitim commented Jan 1, 2022

Thanks for getting in touch. Would you mind changing this PR to merge into my "rotation" branch, please? I will then take a look when I get a moment.

Sure no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants