Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.15] Fix deepcopy gen #15493

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Sep 3, 2024

Fixes #

Proposed Changes

  • See Fix deepcopy gen #15492 (review)
  • I tested by deleting all zz_* files find ./pkg -type f -name 'zz*.go' | xargs rm.
  • No need to migrate to the new kube code gen thingy I think. Goal is to fix that generated file.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@skonto skonto requested review from dsimansk and removed request for izabelacg and ReToCode September 3, 2024 10:48
@skonto skonto changed the title Fix deepcopy gen [RELEASE-1.15] Fix deepcopy gen Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (038a181) to head (db31847).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15   #15493   +/-   ##
=============================================
  Coverage         84.52%   84.53%           
=============================================
  Files               219      219           
  Lines             13595    13595           
=============================================
+ Hits              11491    11492    +1     
  Misses             1735     1735           
+ Partials            369      368    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link

knative-prow bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7176ca5 into knative:release-1.15 Sep 3, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants