Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] For satefulset kafka dispatchers we ignore the replica #1891

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1889

statefulset kafka dispatcher have a managed scaling via kafka controller, hence we ignore replica on those

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (69e97a2) to head (ed766e3).
Report is 1 commits behind head on release-1.15.

Files with missing lines Patch % Lines
pkg/reconciler/common/workload_override.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #1891      +/-   ##
================================================
- Coverage         66.36%   66.31%   -0.05%     
================================================
  Files                53       53              
  Lines              2081     2084       +3     
================================================
+ Hits               1381     1382       +1     
- Misses              586      587       +1     
- Partials            114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2024
matzew and others added 3 commits September 20, 2024 08:52
…ontroller handles it. also they are not HPAs

Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the cherry-pick-1889-to-release-1.15 branch from 32f6b74 to ed766e3 Compare September 20, 2024 06:52
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
Copy link

knative-prow bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 98afaa5 into knative:release-1.15 Sep 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants