-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the dependencies and fixed the eventing upgrade tests #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgencur: 0 warnings.
In response to this:
Reproduce errors from #1884 and prevent masking error.
Fixes #
Proposed Changes
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 53 53
Lines 2081 2081
=======================================
Hits 1381 1381
Misses 586 586
Partials 114 114 ☔ View full report in Codecov by Sentry. |
1142066
to
1f81c6f
Compare
Thank @mgencur for the pretty vendoring of the dependencies. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add changes from #1884 and vendor eventshub.
Fixes #
Proposed Changes
Release Note