[release-1.14]: Configure the securityContext, resources and pod annotations in helm #1872
Conversation
knative-prow
bot
added
approved
houshengbo
changed the title
houshengbo
changed the title
| @@ -48,6 +48,10 @@ metadata: | |||
| app.kubernetes.io/component: operator-webhook | |||
| app.kubernetes.io/version: "{{ .Chart.Version }}" | |||
| app.kubernetes.io/name: knative-operator | |||
| {{- if and .Values.knative_operator.operator_webhook.annotations }} | |||
There was a problem hiding this comment.
I think the annotations under the metadata are not necessarily the same as the annotations on the template/metadata.
There was a problem hiding this comment.
Just remove this section.
| @@ -114,14 +130,23 @@ spec: | |||
| value: knative.dev/operator | |||
| - name: KUBERNETES_MIN_VERSION | |||
| value: "{{ .Values.knative_operator.kubernetes_min_version }}" | |||
| {{- if and .Values.knative_operator.operator_webhook.securityContext }} | |||
| securityContext: | |||
There was a problem hiding this comment.
There is also another securityContext on the pod level
There was a problem hiding this comment.
but the yaml does not have it by default, if .Values.knative_operator.operator_webhook.securityContext is not available, do not add it.
| @@ -2,7 +2,29 @@ knative_operator: | |||
| knative_operator: | |||
| image: gcr.io/knative-releases/knative.dev/operator/cmd/operator | |||
| tag: {{ tag }} | |||
| securityContext: | |||
There was a problem hiding this comment.
let's rename to containerSecurityContext in case we want to add pod securityContext later
see istio https://bbgithub.dev.bloomberg.com/kaas-helm-charts/istio-gateway/blob/main/values.yaml#L40
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.15 |
|
@houshengbo: new pull request created: #1876 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixed: #1869