Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set GOTOOLCHAIN=local #471

Merged
merged 1 commit into from
Jul 23, 2024
Merged

🐛 Set GOTOOLCHAIN=local #471

merged 1 commit into from
Jul 23, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Jul 22, 2024

Which issue(s) this PR fixes:

Fixes https://cloud-native.slack.com/archives/C04LY4M2G49/p1721635801546009

Changes

  • 🐛 Set GOTOOLCHAIN=local

/kind bug
/cc @ReToCode

@knative-prow knative-prow bot requested a review from ReToCode July 22, 2024 21:18
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
Copy link

knative-prow bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cbf5843 into main Jul 23, 2024
16 checks passed
@cardil cardil deleted the bugfix/gotoolchain-local branch July 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants