Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: preventing dubios ownership repository error on git unit tests #2499

Conversation

jrangelramos
Copy link
Contributor

Changes

This chages are meant to preventing dubios ownership repository error on git unit tests (running on Prow/CI)

Sample error observed on midstream CI

--- FAIL: TestTemplates_Remote (0.01s)
    templates_test.go:184: failed to get repository from URI ("http://127.0.0.1:38599/repository.git"): failed to clone repository: unexpected client error: unexpected requesting "http://127.0.0.1:38599/repository.git/info/refs?service=git-upload-pack" status code: 500
fatal: detected dubious ownership in repository at '/go/src/github.com/openshift-knative/kn-plugin-func/pkg/functions/testdata/repository.git'
To add an exception for this directory, call:

	git config --global --add safe.directory /go/src/github.com/openshift-knative/kn-plugin-func/pkg/functions/testdata/repository.git

Copy link

knative-prow bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.04%. Comparing base (81169a4) to head (4ec6f48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/testing.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
+ Coverage   61.54%   67.04%   +5.49%     
==========================================
  Files         129      129              
  Lines       15344    11938    -3406     
==========================================
- Hits         9444     8004    -1440     
+ Misses       4973     2968    -2005     
- Partials      927      966      +39     
Flag Coverage Δ
e2e-test 36.60% <ø> (ø)
e2e-test-oncluster 33.41% <ø> (ø)
e2e-test-oncluster-runtime 29.45% <ø> (?)
e2e-test-runtime-go 26.61% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 26.00% <ø> (?)
e2e-test-runtime-quarkus 26.09% <ø> (?)
e2e-test-runtime-rust 25.14% <ø> (?)
e2e-test-runtime-springboot 25.15% <ø> (?)
e2e-test-runtime-typescript 26.08% <ø> (?)
integration-tests 53.07% <50.00%> (+2.33%) ⬆️
unit-tests 51.28% <50.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/test unit-tests

@knative-prow knative-prow bot merged commit 84f4caf into knative:main Sep 13, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants