remove prints, comment

Signed-off-by: David Fridrich <[email protected]>

cmd/deploy.go

@@ -334,14 +334,11 @@ func runDeploy(cmd *cobra.Command, newClient ClientFactory) (err error) {
 			// TODO: gauron99 - temporary fix for undigested image direct deploy
 			// (w/out build) This might be more complex to do than leaving like this
 			// image digests are created via the registry on push.
-			fmt.Printf("justBuilt '%v'; justPushed '%v'\n", justBuilt, justPushed)
-			fmt.Printf("builtImage '%v'; deployimage '%v'\n", f.Build.Image, f.Deploy.Image)
 			if (justBuilt || justPushed) && f.Build.Image != "" {
 				// f.Build.Image is set in Push for now, just set it as a deployed image
 				f.Deploy.Image = f.Build.Image
 			}
 		}
-		fmt.Printf("builtImage '%v'; deployimage '%v'\n", f.Build.Image, f.Deploy.Image)
 		if f, err = client.Deploy(cmd.Context(), f, fn.WithDeploySkipBuildCheck(cfg.Build == "false")); err != nil {
 			return
 		}
@@ -787,39 +784,6 @@ func printDeployMessages(out io.Writer, f fn.Function) {
 	}
 }
 
-// isUndigested returns true if provided image string 'v' is valid ( by
-// by acceptable standards -- tagged, untagged -> assuming :latest) and false if
-// not. It is lenient in validating - does not always throw an error, just
-// returning false in some scenarios.
-// func isUndigested(v string) (validTag bool, err error) {
-// 	if v == "" {
-// 		// specif image was not given
-// 		err = fmt.Errorf("provided image is empty")
-// 		return
-// 	}
-// 	if strings.Contains(v, "@") {
-// 		// digest has been processed separately
-// 		return
-// 	}
-// 	vv := strings.Split(v, ":")
-// 	if len(vv) < 2 {
-// 		// assume user knows what hes doing
-// 		validTag = true
-// 		return
-// 	} else if len(vv) > 2 {
-// 		err = fmt.Errorf("image '%v' contains an invalid tag (extra ':')", v)
-// 		return
-// 	}
-// 	tag := vv[1]
-// 	if tag == "" {
-// 		err = fmt.Errorf("image '%v' has an empty tag", v)
-// 		return
-// 	}
-
-// 	validTag = true
-// 	return
-// }
-
 // isDigested returns true if provided image string 'v' has digest and false if not.
 // Includes basic validation that a provided digest is correctly formatted.
 // Given that image is not digested, image will still be validated and return

pkg/docker/runner_int_test.go

@@ -108,6 +108,10 @@ func TestRunDigested(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), time.Minute*10)
 	t.Cleanup(cancel)
 
+	// TODO: gauron99 - if image-digest-on-build is implemented, rework this
+	// to fit this schema -- build image (get digest) then run from temporary dir
+	// such that its .func stamp is not considered. All of this to remove the
+	// external pre-built container dependency
 	image := testImageWithDigest
 	prePullTestImages(t, image)