Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Printrun 2.1.0 #1425

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

rockstorm101
Copy link
Collaborator

It's been a year since the last update but I believe the last blocker for a new release is dealt with now so here we are! If anyone knows of any other blockers, please speak up now. Any additions/improvements to the changelog are welcome as well.

Congratulations to everyone who made this possible!

@DivingDuck
Copy link
Collaborator

DivingDuck commented May 25, 2024

Only 3 minor suggestions :)

  • Should we add neofelis2X to the developer list? He did some great work in polishing the UI, support for MacOS, rework for projector tool and testing for this release. (CONTRIBUTORS.md and printrun/pronterface.py, about dialog)

  • info.SetCopyright('(C) 2011 - 2020')

    Change of info.SetCopyright('(C) 2011 - 2020') to info.SetCopyright('(C) 2011 - 2024')

  • We add support for Windows 32 bit again and probably it will be the last version with 32bit support.

Edit:
I did some tests with both X32 and X64 for Pronterface and Pronsole. Guess, what I found...

You need to wait a little bit (again...). There is a problem with SD printing via Pronterface that causes a NoneType TypeError. It do not break printing but as result there is no print status available when print from SD-Card. I have already identify the problem and fixed it locally but it is a little bit too late now for testing the modification. I will send a update tomorrow.

@DivingDuck
Copy link
Collaborator

I add an additional PR #1426 that will fix the type error in Pronterface, a minor quirk with print status via SD printing in Pronsole, the mentioned adjustment for copyright year and a fix for issue #1420 on the fly because it was an easy one.

@rockstorm101
Copy link
Collaborator Author

  • Should we add neofelis2X to the developer list?

Totally agree. I just added them.

@rockstorm101
Copy link
Collaborator Author

I just force-pushed again cause I forgot to add the line about supporting 32bits on Win. I believe the changelog is complete now. Please let me know if you think there's anything missing.

@DivingDuck
Copy link
Collaborator

A quite impressive change log. 👍
I just download the windows versions for a quick test on all versions and the test was running fine. I think we can push the new release :)

Copy link
Collaborator

@DivingDuck DivingDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rockstorm101 rockstorm101 merged commit b382917 into kliment:master May 26, 2024
12 checks passed
@rockstorm101 rockstorm101 deleted the release-2.1.0 branch May 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants