Add IPv6 support to Kiwix Server #673
Conversation
|
@aryanA101a Now that kiwix/libkiwix#1074 is (almost) ready, we should focus on this PR. Is this PR ready for a new review? Could you please give a specific feedback to each comment of the reviewer? |
|
@aryanA101a Can we complete this PR? |
|
I'm not sure why the build is failing. Is it due to |
|
@aryanA101a This is something out of the scope of this PR. I'm more concerned about the fact that other parts of the CI (like compilation on Linux) is not triggered at all! |
Should be fixed by #679 |
docs/kiwix-serve.rst
Outdated
| all : Listen for connections from all IP addresses (IPv4 and IPv6). | ||
| ipv4 : Listen for connections from all IPv4 addresses. | ||
| ipv6 : Listen for connections from all IPv6 addresses. |
There was a problem hiding this comment.
- from → on
- Make it a bulleted list (start each line with a
-). Build (vianinja doc) and check the documentation to make sure that it looks nice.
src/man/kiwix-serve.1
Outdated
| all : Listen for connections from all IP addresses (IPv4 and IPv6). | ||
| .br | ||
| ipv4 : Listen for connections from all IPv4 addresses. | ||
| .br | ||
| ipv6 : Listen for connections from all IPv6 addresses. |
|
Since I actually performed the proposed changes locally (in order to find out the proper formatting of documentation) I also committed them. If you are fine with them, please rebase&fix-up and we will merge this PR. |
|
@aryanA101a Please squash everything in one commit |
Fixes #545
depends on kiwix/libkiwix#1074