Adapt kiwix-desktop to new libkiwix API. #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LocalKiwixServer` is "just" a UI to start/configure or stop the server. One important change is that instead of having one server we configure and start/stop when needed, we are now creating a new server each time we want to start the server. It doesn't change the behavior, as libkiwix is destroying/recreating for us, but it will help us to use the new API which use a `Server::Configuration`.
Now libkiwix `Manipulator`, `Server`, `NameMapper`, ... take shared_ptr. We have to store all those object using shared_ptr instead of as plain object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt code to kiwix/libkiwix#830