Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzering for OTP 27 #50

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix dialyzering for OTP 27 #50

merged 1 commit into from
Jun 20, 2024

Conversation

kivra-pauoli
Copy link
Contributor

Motivation

We have an internal dependency that uses this lib. and it's failing dialyzer analysis.

Further considerations

{dialyzer, [{plt_extra_apps, [xmerl, erlsom]}]}. is required because otherwise the applications aren't loaded for analysis (if e.g. they were in .app.src this wouldn't be required).

erlsom:simple_form() |
term() | % check erlsom:simple_form/1,2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of a better way to do this.

  1. the erlsom:simple_form() type doesn't exist
  2. in our tests, for example, the return is a tuple, but without any proper "form"

My goal in adding the comment is to have the consumer look at the dependency, if they need it for that specific type.

@kivra-pauoli kivra-pauoli merged commit cdca6f8 into master Jun 20, 2024
2 checks passed
@kivra-pauoli kivra-pauoli deleted the fix/spec branch June 20, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants